Skip to content

[rlgl] Remove unused 'format' parameter in rlGenTextureMipmaps#4672

Closed
Not-Nik wants to merge 1 commit intoraysan5:masterfrom
Not-Nik:mipmap_unused_format
Closed

[rlgl] Remove unused 'format' parameter in rlGenTextureMipmaps#4672
Not-Nik wants to merge 1 commit intoraysan5:masterfrom
Not-Nik:mipmap_unused_format

Conversation

@Not-Nik
Copy link
Copy Markdown
Contributor

@Not-Nik Not-Nik commented Jan 9, 2025

Unless I had a major oversight somewhere, that parameter isn't used, so let's leave it out entirely.

@Bigfoot71
Copy link
Copy Markdown
Contributor

I had already proposed it some time ago and the final opinion is that it was better to keep it
See: #4583

About the format parameter in rlGenTextureMipmaps(), it was kept there for a future implementation for OpenGL 1.1 that required the data size in memory... but implementation was removed at some point in raylib live...

@Not-Nik
Copy link
Copy Markdown
Contributor Author

Not-Nik commented Jan 9, 2025

So we had a 1.1 implementation, then it was removed and now we're waiting for something to happen so we can add it again? Regardless, unless there's solid plans to add a 1.1 implementation, I reckon it would be OK to just remove the parameter(s) for now and add them again once the implementation is actually there.

@raysan5
Copy link
Copy Markdown
Owner

raysan5 commented Jan 10, 2025

As commented, we are keeping this parameter just in case it can be required on a future implementation (OpenGL 1.1, software render, old consoles...)

@raysan5 raysan5 closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants